search

waltsims / k-wave-python

A Python interface to k-Wave GPU accelerated binaries
https://k-wave-python.readthedocs.io/en/latest/
GNU General Public License v3.0
105 stars 31 forks source link

Refactor make_line in kwave.utils.mapgen #263

Open waltsims opened 9 months ago

waltsims commented 9 months ago

Refactor make_line. The function is too long and confusing and could be broken down into subfunctions and simplified.

Harish-M-2003 commented 9 months ago

@waltsims Would you mind assigning this issue to me? I would appreciate the opportunity to work on it.

waltsims commented 9 months ago

Hey Harish,

welcome! I look forward to your PR.

Best, Walter

Harish-M-2003 commented 9 months ago

Hi @waltsims ,

Thank you for the warm welcome!

Best regards, Harish

waltsims commented 8 months ago

Hey @Harish-M-2003, Checking in on this Issue. Do you think you would be able to close a PR by the deadline for the v0.3.3 milestone on April 3rd?

Harish-M-2003 commented 8 months ago

Unfortunately, I regret to inform you that I am unable to continue with it at this time. I apologize for any inconvenience this may cause

waltsims commented 8 months ago

No problem.