Closed waltsims closed 2 weeks ago
TODOs:
Attention: Patch coverage is 79.64602%
with 23 lines
in your changes missing coverage. Please review.
Project coverage is 72.53%. Comparing base (
2f5060a
) to head (6f40ce0
). Report is 2 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
kwave/options/simulation_execution_options.py | 79.46% | 14 Missing and 9 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I went back to basics and was able to get the desired behavior without changing the API
I'll keep working on a better doc string
Perhaps we should make the default value of threadbinding false thereby removing the None case. This would mean a better handling of darwin is required.
@faridyagubbayli ?
close #473.