search

waltz-controls / axsis-xes

AXSIS XES spectrometer
MIT License
0 stars 0 forks source link

Refactoring #4

Open Ingvord opened 2 years ago

Ingvord commented 2 years ago

Key points:

Zelenyy commented 2 years ago

I begin work and have some question:

Ingvord commented 2 years ago

Sorry for the late reply

In first task: It may be better to give the controller number as CLI argument

There's no any controller number. Controller is identified by an upstream hardware IP and port, see task 2. So basically there's no need to pass anything except IP and a port

In second task: what service IP and port need pass?

The IP and the port of the upstream hardware. Currently it is done in the GUI. When one starts the GUI it asks for two IPs and ports - these are the same thing.

In six task: Am I right that you need to run the flask server from axsis.magix.py or check what server already running?

In the end result there won't be a flask server anymore. Only Magix clients produced from the other tasks. In the meantime however it is ok to have both.

Hope this clarifies. Thanks

Zelenyy commented 2 years ago

@Ingvord

There's no any controller number. Controller is identified by an upstream hardware IP and port, see task 2. So basically there's no need to pass anything except IP and a port

Maybe then pass ip and port as cli argument? Then don't need split axis.magix.py on two.

Ingvord commented 2 years ago

Maybe then pass ip and port as cli argument? Then don't need split axis.magix.py on two.

Yes, sure. That's what is intended