search

waltz-controls / rfc

RFCs for Waltz-Controls
MIT License
2 stars 3 forks source link

Rename "source" to "type", "spec" or "specification" #2

Closed altavir closed 4 years ago

altavir commented 4 years ago

Source is confusing because I would think that it marks the source device.

altavir commented 4 years ago

Target seems to be useless because the source designates specification and not the actual source.

Ingvord commented 4 years ago

Idea here is to indicate a kind of a "place" from where a message originates IMHO source better fits for this purpose rather than type, another alternative that I like is upstream, but this is immediately triggers association with git forks... (maybe only my own feeling though)

altavir commented 4 years ago

The problem is that we have the source system and the source device, so it is confusing. Your source de-facto designates the message format, not its origin.

Ingvord commented 4 years ago

The problem is that we have the source system and the source device, so it is confusing.

Completely agree

Your source de-facto designates the message format, not its origin.

Not really. Message format is defined by this RFC. source is really a place of origin.

Maybe call it origin?

altavir commented 4 years ago

origin is OK

Ingvord commented 4 years ago

Done in 7c21006