search

waltz-controls / waltz-grid-widget

0 stars 0 forks source link

Implement GridWidget #1

Closed Ingvord closed 3 years ago

Ingvord commented 5 years ago

subj

HelgaMond commented 4 years ago

The issue can be solved with DataView

An example with tree from which one can drag-n-drop to a predefined template.

Drag-and-Drop between Different Components

Advanced Drag-and-Drop options

Drag-n-Drop within Views

Ingvord commented 4 years ago

Hi, I have got some feedback from our beamline scientists today.

The following would be nice to have:

1) ~change bg color~ 2) ~embedded plots for attributes~ 3) ~fine tuning controls for attributes polling e.g. one attribute is polled every 250 ms, other - every 5 mins~ 4) ~void commands~ 5) ~setting bar - geometry (dropdown list with perdefined number 2x2, 3x2, 3x3, 4x3), bg color~ 6) ~simplify state~

    {
       devices:[{host,device,attributes:[{name, value}],commands:[{name}]}]
       geometry:{rows,cols},
       bgcolor:'string'
    }

I would suggest to have a teleconf meeting to discuss those in details

Ingvord commented 4 years ago

Hi,

In general the widget seems now to be almost ready for testing as for 1.0.1-rc7.

There are few minor issues:

1) set attribute polling in ms. Maybe it is better to use range setter with 100 ms step and minimum value of 100 ms, smth like webix counter 2) move cog icon for device configuration to DeviceWidget header, as it is now occupies to much space 3) possibility to name plots 4) would be nice to have documentation on how to react on widget's internal changes e.g. change attribute visibility and polling, command execution etc

Thanks!

Ingvord commented 3 years ago

GridWidget has been successfully integrated into Waltz, see PR-257

There are still some UI/UX issues as well as API ones. But those can be addressed in separate issues