search

waltzofpearls / dateparser

Parse dates in commonly used string formats with Rust.
MIT License
41 stars 8 forks source link

Run check & test jobs on Linux, macOS, & Windows with stable, beta, & nightly Rust #38

Closed autarch closed 1 year ago

autarch commented 1 year ago

This would be faster (and less repetitive) if I combined the check & test jobs in one but I didn't want to change too much at first. If you want, I'm happy to make that change.

For some reason this didn't run in Actions when I pushed it to my fork, so I'm not sure it works yet. Maybe it will run when I create this PR.

autarch commented 1 year ago

I'd also note that if you want a really extensive change I can easily add a lot more platforms by using actions-rust-cross (which I wrote). This would allow testing on many different Linux CPU architectures.

autarch commented 1 year ago

BTW, the reason I started working on this is that I'm seeing an odd failure from this crate when running tests of my own project on Windows. I think the handling of local time zones on that platform is different.

autarch commented 1 year ago

Thanks for the update!

I had another look, and left 2 comments. Same comments as before, but for different job. I will merge this PR the test job is updated.

I fixed those. But FWIW, I think it'd be much better to merge the two jobs. As it stands, you're spinning up a new set of VMs for each job, which is way slower than just running cargo check followed by cargo test in the same VM.

waltzofpearls commented 1 year ago

@autarch yeah, that makes sense. I will make that change after merging this PR.