wamps-jp / pe

0 stars 0 forks source link

`find` command too restrictive with multiple inputs #7

Open wamps-jp opened 10 months ago

wamps-jp commented 10 months ago

The find command only works if all searched inputs (such as n/ or p/) are present in the final entry.

Calling find n/bernice p/999 on the below example will find no entries:

image.png

image.png

I believe this is too restrictive for many users, who may want to find multiple employees via multiple fields.

While this function is likely working as intended, I believe this functionality is quite useful.

soc-pe-bot commented 9 months ago

Team's Response

Thank you for your input. We acknowledge that having an OR search across multiple attributes can be useful at times but we felt that the more frequently used way is for HR staff members to want to use an AND search across multiple attributes. i.e. HR staff members would likely want to find an employee who has the name Alex and phone number 999 rather than employees with either the name Alex or phone number 999. We feel that this is not in scope because we specified in the UG that the find command finds employees whose attributes satisfy all the search parameters. i.e. AND search and we also feel that adding the OR search is less important than implementing the AND search.

Screenshot 2023-11-19 at 7.33.10 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]