wanadev / PhotonUI

A javascript framework to create user interfaces
http://wanadev.github.io/PhotonUI/
BSD 3-Clause "New" or "Revised" License
63 stars 20 forks source link

Memory leak select #171

Closed Rincelent closed 1 year ago

Rincelent commented 1 year ago

Correct a small memory leak happening when destroying select widget

flozz commented 1 year ago

The changes looks good so far. There is only some coding style issue:

$ grunt jshint
Running "jshint:all" (jshint) task

   src/composite/select.js
    117 |        if (this.__displayValue) this.__displayValue.destroy();
                                          ^ Expected '{' and instead saw 'this'.
    329 |        if (this.__displayValue) this.__displayValue.destroy();
                                          ^ Expected '{' and instead saw 'this'.
    330 |        if (this.__popupMenu) this.__popupMenu.destroy();
                                       ^ Expected '{' and instead saw 'this'.

>> 3 errors in 54 files
flozz commented 1 year ago

Thank you :)