search

wanadev / holes-in

A javascript library to generate 3D mesh from a 2D outer path and 2D inner paths
https://wanadev.github.io/holes-in/
Other
18 stars 4 forks source link

An in-range update of uglify-js is breaking the build 🚨 #6

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 3.0.24 of uglify-js just got published.

Branch Build failing 🚨
Dependency uglify-js
Current Version 3.0.23
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As uglify-js is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this :muscle:

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build failed [Details](https://travis-ci.org/wanadev/holes-in/builds/251415224?utm_source=github_status&utm_medium=notification)
Release Notes v3.0.24

 

Commits

The new version differs by 11 commits.

  • bd7be07 v3.0.24
  • 71ee91e handle duplicate argument names in collapse_vars (#2215)
  • 4f70d2e inlining of static methods & constants (#2211)
  • 4b6ca5e inline property access of object literal (#2209)
  • 9306da3 suppress collapse_vars of this as call argument (#2204)
  • 1ac25fc improve compress granularity through typeofs (#2201)
  • 5f046c7 minor clean-ups to evaluate (#2197)
  • af0262b improve parenthesis emission (#2196)
  • 6b3aeff clean up TreeWalker.pop() (#2195)
  • 20e4f82 refactor throw usage within compress (#2193)
  • f3a487a document fast mangle-only minify mode (#2194)

See the full diff

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 7 years ago

After pinning to 3.0.23 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.