search

wanam / YouTubeAdAway

Xposed module to block YouTube ads on the official YouTube Android App
GNU General Public License v3.0
693 stars 56 forks source link

Fix get version youtube A12 & added block general ads #123

Closed Dev4Mod closed 1 year ago

Dev4Mod commented 1 year ago

I added code to block ads on home screen based on information present in revanced hope it can be accepted. Also fix issue getting youtube version on android 12

wanam commented 1 year ago

Hello @Dev4Mod,

Thanks for your contribution! Unfortunately, it seems your changes are not working, at least with YouTube 17.46.xx. By reading your changes, I see that you are using the same fingerprint to identify the ad classes, so I think you should add your ad processing inside the existing brute-force methods to reduce perf issues.

I will try (after vacations :) ) to merge those brute-force methods.

A scope resource is missing in your commit.

wanam commented 1 year ago

Hello @Dev4Mod , Thank you again for your contribution, I didn't have much time to correctly test your changes- but it seems working so far.

I will have to try to improve the brute force perfs, to avoid getting the ad cards during the first load of the app, finding the hooks takes currently up to 10 seconds, we will need maybe to use shared prefs to avoid brute forcing on each reboot.

I merged off-line your commits with some minor changes, so I'm closing this PR!