search

wanam / YouTubeAdAway

Xposed module to block YouTube ads on the official YouTube Android App
GNU General Public License v3.0
672 stars 54 forks source link

oopsa: versionCode not increased? #135

Closed IzzySoft closed 1 year ago

IzzySoft commented 1 year ago

The APK attached to tag 5.0.6 shares the versionCode with the one from 5.0.5, maybe you forgot to increase it?

package: name='ma.wanam.youtubeadaway' versionCode='505' versionName='5.0.6'
wanam commented 1 year ago

You are right, I forgot to update the versionCode, fortunately lsposed repo seems to push anyway

IzzySoft commented 1 year ago

Not sure if that's fortunate, or if a hint were better: there won't be any update notification, and Android will not consider this an update as versionCode was not increased. It was updated to my repo nevertheless, but installing the update will require a manual download of the APK and side-loading it with adb install -r; the F-Droid clients won't offer to update, because … well, I repeat myself :see_no_evil: Next release will fix that then. Thanks for checking!

wanam commented 1 year ago

No problems, I will push an other update with the correct version code.

wanam commented 1 year ago

Fixed on 5.0.7