wanam / YouTubeAdAway

Xposed module to block YouTube ads on the official YouTube Android App
GNU General Public License v3.0
681 stars 56 forks source link

YouTube videos appearing with no titles #58

Closed blistex closed 1 year ago

blistex commented 6 years ago

Hi Wanam,

I'm sure u are busy but can you maybe update us once in a while? there are some issues opened since the new update saying they still get ads or the yt app is crashing. Many me included provided you with our logs. Can u please update us on this issue? Do maybe few people experience this. Did u find the cause? are u planning on fixing it? We did our part by posting our logs can please tell us what's going on?

Thank you.

wanam commented 6 years ago

Sorry, i was on vacation for the past two weeks. Actually what's happening here is that I'm trying to avoid hooking proguarded sources, but it doesn't seem to be enough, because YT uses the same views layers to play ordinary videos and invideo ads as well.

I built a test update yesterday, I force the expiration of the invideo ads, and it seems to work, but it may crash ART while trying to look up a large number of YouTube classes causing YouTube FC (on Oreo), Robert is aware of this bug: 02-02 14:39:27.428  4098  4098 F DEBUG   : Abort message: 'quick_exception_handler.cc:326] Check failed: calleemethod != nullptr ma.wanam.youtubeadaway.Xposed.debug'

Here's the test version, try it and report back.

morfikov commented 6 years ago

I just tested the new version and it looks pretty stable to me (android 7.0):

Xposed : YouTube: com.google.android.youtube 13.03.58 loaded with module version 4.1.0

I don't see any problems with the YT app, and also I checked over 100+ vids and I didn't notice any commercials.

wanam commented 6 years ago

@morfikov Yes i reproduced this bug on Oreo only.

blistex commented 6 years ago

After installing and first reboot, blocking ads in videos worked fine for 30-40 vids. Start/Home tab looks broken (no titles/information). Little ads under videos appeared in 2 videos. And after a reboot just disabling deleting a overlay + deactivating appsettings to see if they effect the Start/Home tab yt app startet crashing right before starting a video.

screenshot_20180203-183323 screenshot_20180203-183222

wanam commented 6 years ago

@blistex what device/OS version is this? Can you disable other modules, try again and post logs?

blistex commented 6 years ago

Alright...

Device S8 screenshot_20180203-194139

Disabled all xposed modules / AppSettings. Removed SubStratum Theme. Still looks like this screenshot_20180203-194008

Still after booting my Phone the FIRST time and start yt, videos play fine and ads get blocked, but after that yt app crashes every time right before the video starts playing.

log doesn't say much xposed_error_20180203_194228.log

wanam commented 6 years ago

I cannot reproduce this issue on a GS7 running the same Android version, please upload the logcat.

blistex commented 6 years ago

never did this logcat thingy but hope this is right... first time few videos i got to play and no ads then the other two times or so app crashed like mentioned before.

alogcat.2018-02-03-20-54-52+0100.txt

Bigdogmacho commented 6 years ago

I've used the latest version 4.1.0 with the latest version of YouTube 13.03.58 and have yet to encounter any in video ads. No crashes of YouTube. No random reboots. No loss in performance. The only ad that I ever come across is when I first open the app and there is a video ad at the top above my suggested videos. I'm running Temasek unofficial version 18.3 (Android 5.1.1) with xposed framework v86 on a t-mobile galaxy note 4.

wanam commented 6 years ago

@blistex I still believe this is related to your theming engine, since there is no such report from the other 13000 users who installed the update the past 3 days, maybe you could try clean up YouTube app data.