search

wanam / YouTubeAdAway

Xposed module to block YouTube ads on the official YouTube Android App
GNU General Public License v3.0
673 stars 56 forks source link

Fix for new youtube version #94

Closed ChristophPech closed 1 year ago

minhng99 commented 6 years ago

Wow nice, could you release an APK meanwhile?

wanam commented 6 years ago

I just released an update, but not based on Christoph patch, i still need more time to test some of his refactoring changes.

ChristophPech commented 6 years ago

One main change is that I am going over all obfuscated classes in the package instead of trying all three letter combinations because they also use four letter classes. The obfuscator might use these one day. Then I am changing the value of the timestamp in beforehook instead of after so I don't need to touch the member variable. While testing it I found out some if the long values are timestamps in milliseconds but some seem to be durations or at least relative values so I set them to zero, but a large value number works as well.

minhng99 commented 6 years ago

I'm still randomly seeing ads when video started with the Wanam's version, also YouTube has crashed once when the video is playing.

There's nothing interesting in the xposed log so I didn't bother...

-------- Original Message -------- On Aug 31, 2018, 10:48 PM, Christoph Pech wrote:

One main change is that I am going over all obfuscated classes in the package instead of trying all three letter combinations because they also use four letter classes. The obfuscator might use these one day. Then I am changing the value of the timestamp in beforehook instead of after so I don't need to touch the member variable. While testing it I found out some if the long values are timestamps in milliseconds but some seem to be durations or at least relative values so I set them to zero, but a large value number works as well.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Aviv258958 commented 6 years ago

I have tried this one and the last update wanam provided. This one works just fine, haven't had much testing tho , loaded 10 videos+ and haven't got any ad yet besides the main screen where you have an ad video but I don't really mind that

Wanam's version doesn't work for me (using Pixel 2 XL, Android 8.1) Thanks for the contribution :)

minhng99 commented 5 years ago

i've compiled the PR from @ChristophPech and it's working really good, thanks! There's not even ads in the video, I'll leave the apk file here: https://drive.google.com/open?id=1PRreR2cBpdt08T0-aTx_1us_CSb5OQxd

street-grease-coder commented 5 years ago

i've compiled the PR from @ChristophPech and it's working really good, thanks! There's not even ads in the video, I'll leave the apk file here: https://drive.google.com/open?id=1PRreR2cBpdt08T0-aTx_1us_CSb5OQxd

thanks for compile, package installer tells me APK file is corrupt Android 7.1.2

minhng99 commented 5 years ago

I installed it successfully, make sure you removed the old one first because signature won't match

street-grease-coder commented 5 years ago

mea culpa, indeed the solution was this simple. I do still see videos at the beginning, but I imagine this might be due to cache files

minhng99 commented 5 years ago

@ChristophPech ads has appeared again in version 13.37.52, could you please check?

ChristophPech commented 5 years ago

@SandPox it should work now again

minhng99 commented 5 years ago

yes, it's working now, if anyone want the prebuilt apk: https://drive.google.com/open?id=1kDBQq7FMIUThD-C1jWI2kjkF8hMYW7rl

uninstall the previous version first if install failed

updated to eeafb5a5e391157bf3a5b0bdd48af132a271f36a

ChristophPech commented 5 years ago

I made the app save the "obfuscation detection" results since they only change on new YT versions. So on the first start it detects the classes and reuses these results on all subsequent starts. Since the detection itself is somehow triggering these #60 problems, this caching I added will help there too. On Android #60 happens only sometimes, but on 8.1 it happens all the time.

ngosang commented 5 years ago

@wanam the official release is not working since 2 months. I'm using this patch, but this should be mainstream so all of us could update with xposed updater.

AuroraWright commented 5 years ago

Can confirm on Android 7.1 and latest Xposed, official 4.3.3 doesn't hide ads at the beginning of videos with YT 13.39.51. This PR fixed the issue

monkey000 commented 5 years ago

Installed @SandPox shared apk. Android8.1 still crashes. YouTube Version 13.34.50. When I open the YouTube app, the home page is displayed, then the app crashes, every time it is like this

minhng99 commented 5 years ago

@monkey000 could you try clear data of youtube app? I'm using 6.0 and latest youtube version, there's no ads or crash here

monkey000 commented 5 years ago

@SandPox Tried to clear the data and still crash. Now I am using the YouTube Vanced module in the Magisk framework, and no ads will appear. Otherwise I will consider whether to open YouTube Premium.

ChristophPech commented 5 years ago

The SandPox binary is from before my fix for 8.1

minhng99 commented 5 years ago

Where's your fix for 8.1? Pretty sure I was complied your latest commit on your repo eeafb5a which is 12 days ago

ChristophPech commented 5 years ago

Sorry, I didn't see you already updated it.

monkey000 commented 5 years ago

@SandPox I am very sorry, it's my fault.I did not see the link you updated later. I downloaded and installed the first apk.

minhng99 commented 5 years ago

@ChristophPech the ads has come back, could you update it?

AuroraWright commented 5 years ago

Which YouTube version? I don't see them on 13.41.53

minhng99 commented 5 years ago

Yes it's that version, only ads in the beginning of the video in like... 3 days ago

rishav394 commented 5 years ago

I see adds too now on the latest version. Only in the starting though. Not in between the video.

minhng99 commented 5 years ago

I'm starting to see some ads between video now

AuroraWright commented 5 years ago

Still nothing here on latest YouTube, are you sure you emptied the YouTube app's data after you installed this fork?

rishav394 commented 5 years ago

Idk can't say anything for sure. Ads have stopped again. Huh. 🤔🤔 Also merge this PR pls ofc after resolving the conflicts.

ngosang commented 5 years ago

Not working in last version :(

street-grease-coder commented 5 years ago

It's stable for me, but some ads keep showing again

acsway878787 commented 5 years ago

It doesn't work on the latest version, any way to fix it? The ads are disturbing.

ngosang commented 5 years ago

@ChristophPech Seems like the original author lost interest... Could you take care of this project or make a fork?

ChristophPech commented 5 years ago

@ngosang I don't have the time to continue this either.

acsway878787 commented 5 years ago

@ChristophPech Maybe you can give me some hint of maintaining this module then I can continue this project. It's really hard to figure out what to do with this only by viewing the codes...

wanam commented 5 years ago

@acsway878787 unfortunately this is how it was done all the time, you need to pinpoint some classes, and try to analyze them based on the json keys strings and logging messages.

minhng99 commented 5 years ago

Try Youtube Vance, it's pretty good

ohyeah521 commented 5 years ago

@ngosang I don't have the time to continue this either.

I just lost my job and I have time to do this. try this: https://github.com/ohyeah521/NoAds-For-YouTube/releases

i had test on my phone, If there is a problem, please submit issues

ngosang commented 5 years ago

Sorry, I'm using Youtube Vance now.