wanasit / chrono

A natural language date parser in Javascript
MIT License
4.61k stars 339 forks source link

Added Italian Locale #460

Open ntotao opened 2 years ago

ntotao commented 2 years ago

Added locales/it translations for Italian Language support

wanasit commented 2 years ago

Hello @ntotao. Thanks for your contribution!! I will try to complete reviewing you change as soon as possible, but there is an obvious feedback I'd like to ask.

Could you also include the tests for the new locale?

The tests are as important if not more important than the parsers. Only with the tests, we can keep the parsers work both for now and in the future. Imagine, if I or other contributors who don't speak Italian trying to refactor or making change to Chrono, we would never know if it works correctly for Italian without your tests.

ghost commented 2 years ago

I can add tests if needed, could you please tell me which one should I translate from English? I've seen not every language have the same amount of files as English.

Thanks.

wanasit commented 2 years ago

@federicodilo Thanks for looking. Sorry for my slow reply.

As you see, tests for different locales are not equally comprehensive. But, in general, the more tests the better.

The tests with the highest priorities (high ROI) are probably:

You also do not need to copy and translate English. It is simply a good place to start, but do whatever input and expected output make sense in the locale.

vetrek commented 6 months ago

Hi @ntotao, any updates :) ?

filippozanfini commented 4 months ago

Any updates on this?

filippozanfini commented 3 months ago

Please merge this @ntotao @wanasit 🙏