search

wanasit / chrono

A natural language date parser in Javascript
MIT License
4.61k stars 340 forks source link

sideEffects should be a boolean or an array #506

Closed danielepolencic closed 1 year ago

danielepolencic commented 1 year ago

When bundling chrono-node, I can observe the following warnings:

▲ [WARNING] The value for "sideEffects" must be a boolean or an array [package.json]

    ../../../../../../../../execroot/my-project/bazel-out/darwin_arm64-fastbuild/bin/node_modules/.aspect_rules_js/chrono-node@2.6.1/node_modules/chrono-node/dist/cjs/package.json:1:33:
      1 │ {"type":"commonjs","sideEffects":"false"}
        ╵                                  ^

I think this was introduced in the latest release.

JoakimNil commented 1 year ago

This property should definitely be a boolean (webpack docs). I can submit a PR to fix this over the weekend @wanasit unless you want to handle it?

wanasit commented 1 year ago

I'm not good at JS build and I haven't looked into this. If you already know what to do, I'd be glad if you could help :)