search

wanasit / chrono

A natural language date parser in Javascript
MIT License
4.61k stars 341 forks source link

[JA] Add support for Hiragana #511

Closed yuichkun closed 1 year ago

yuichkun commented 1 year ago

TL;DR

This PR adds support for Hiragana(ひらがな) in the Japanese date parser. I didn't know the best way of treating Hiragana/Kanji, so for now I just did it in the most straight forward, or redundant way. If you have any thoughts on how to improve this, I'd love to challenge myself!

In addition to adding support for Hiragana, I also added some test cases that seemed to be missing.

Btw, thank you so much for writing this library, and I really appreciate how well this library is maintained.

wanasit commented 1 year ago

Hello @yuichkun. Thank you so much for the change.

Could you please take a look at my comments, especially about the test? It would be nice if you can address them.

yuichkun commented 1 year ago

Hi @wanasit , thank you for your feedback, and I think I've fixed the points you mentioned. Please let me know if there's anything else I should reconsider!

wanasit commented 1 year ago

I apologize that I forgot to publish the new version for months. This change has been included in v2.6.4.