search

wanasit / chrono

A natural language date parser in Javascript
MIT License
4.61k stars 340 forks source link

Main branch failing test. #538

Open HendrikJan opened 1 year ago

HendrikJan commented 1 year ago

Hi,

I'm trying to create a PR for a minor improvement for the Dutch language.

Unfortunately I cannot create a commit because Husky won't let me. Husky won't let me because the test "Compare with native js" fails.

Should I wait for a fix for this test before creating a PR?

Kind regards, Hendrik Jan

HendrikJan commented 1 year ago

I've now created a PR using "--no-verify", but questing remains if I should wait for the test to pass.

wanasit commented 1 year ago

Hello @HendrikJan.

Could you share more specific details about the cases that are failing? or what error message do you get?

HendrikJan commented 1 year ago

The error I get is this: image

Since you already accepted my PR this failing test is not blocking me anymore (therefore I updated the title of this issue).