wanasit / katakana

Training machine to write Katakana using Sequence-to-Sequence technique
66 stars 18 forks source link

About the method of passing encoder states to decoder #6

Open mrgloom opened 4 years ago

mrgloom commented 4 years ago

Based on lstm_seq2seq.py example seems there is a better way to pass encoder states to decoder:

https://github.com/keras-team/keras/blob/7a39b6c62d43c25472b2c2476bd2a8983ae4f682/examples/lstm_seq2seq.py#L129-L132

https://github.com/keras-team/keras/blob/7a39b6c62d43c25472b2c2476bd2a8983ae4f682/examples/lstm_seq2seq.py#L139-L141

compared to

https://github.com/wanasit/katakana/blob/72d2f91066aa22531f242ba67ff9092ca5f2394b/katakana/model.py#L62-L65