coveralls
commented
4 years ago Pull Request Test Coverage Report for Build 156ea232-df9a-4a00-93ac-3dd044a2e90f
- 26 of 28 (92.86%) changed or added relevant lines in 1 file are covered.
- 131 unchanged lines in 23 files lost coverage.
- Overall coverage increased (+5.0%) to 63.938%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| wandb/data_types.py | 26 | 28 | 92.86% | ||
| <!-- | Total: | 26 | 28 | 92.86% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| tests/utils/mock_server.py | 1 | 88.73% | ||
| wandb/apis/internal_runqueue.py | 1 | 24.81% | ||
| wandb/internal/internal_api.py | 1 | 48.09% | ||
| wandb/internal/meta.py | 1 | 72.59% | ||
| wandb/sdk/wandb_run.py | 1 | 68.0% | ||
| wandb/util.py | 1 | 64.24% | ||
| tests/test_datastore.py | 2 | 97.83% | ||
| tests/test_util.py | 2 | 97.44% | ||
| tests/utils/notebook_client.py | 2 | 72.22% | ||
| wandb/cli/cli.py | 2 | 61.54% | ||
| <!-- | Total: | 131 | --> |
| Totals | |
|---|---|
| Change from base Build beca34e7-b73b-4e3f-ae33-7735194a209f: | 5.0% |
| Covered Lines: | 11246 |
| Relevant Lines: | 17589 |
nbardy
I split out the bugfixes from the test PR so they can be merged sooner.
Fixes an issue where a
wandb.Imageobject could not be reused in an image array. Ourseq_to_jsoncode relies on a pattern, but if the image is already logged in a different step, its path is set to something different than expected. Now bind_to_run when be called for an object every time it's logged.This has the downside of uploading a file multiple times even if it is the same file, but that downside was already there with the spriting approach in cli-original. Since we want to keep the filenames out of the metadata for performance reasons this is the best we can do for now.
When we move media to artifacts, this problem will be solved for us in a graceful way.
Fixes dataframes in
wandb.TableFixes image format always being set to png for
seq_to_json