search

wandb / client-ng

Experimental wandb CLI and Python API - See Experimental section below.
http://wandb.com
16 stars 7 forks source link

wandb gc #206

Closed farizrahman4u closed 3 years ago

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 49b1c642-90f4-4265-b243-4293ee645e2d

Changes Missing Coverage Covered Lines Changed/Added Lines %
wandb/sync/sync.py 34 49 69.39%
wandb/cli/cli.py 28 71 39.44%
<!-- Total: 89 147 60.54% -->
Totals Coverage Status
Change from base Build 876d7d9b-2a78-4236-ab7f-3c1098d32771: 0.2%
Covered Lines: 12915
Relevant Lines: 21169
💛 - Coveralls
raubitsj commented 3 years ago

Nice cleanup,

Couple of functionality notes: 1) I think you are missing the ability to delete online runs. Since they are not explicitly marked synced, you could probably assume they are synced? I assume that is what the old 'gc' command was doing. In the future we could try harder to verify by reading the end of the binary log file. 2) Lets add a flag to let you remove non-interactively. --clean-force? 3) I dont think we need to show the synced directories in the summary, just the count is good since it that is what the user really needs to see. Eventually it could be count and amount of storage that can be freed 4) Does it make sense to support wandb sync --clean DIR? If we dont support it, we should at least error on this usage. 5) I think we should sort the run directories? oldest first? not sure 6) when you are asking the user to confirm the delete, that is where you can show the synced directories you are about to delete. (instead of in the summary).