wandb / examples

Example deep learning projects that use wandb's features.
http://wandb.ai
1.12k stars 290 forks source link

feat(peft): add llama token classification example #525

Closed SauravMaheshkar closed 4 months ago

SauravMaheshkar commented 5 months ago

Adds notebook for Token Classification example for Fine-tuning llama 2 for Named Entity Recognition.

Request for Review: @tcapelle @soumik12345

review-notebook-app[bot] commented 5 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 5 months ago

Thanks for contributing to wandb/examples! We appreciate your efforts in opening a PR for the examples repository. Our goal is to ensure a smooth and enjoyable experience for you 😎.

Guidelines

The examples repo is regularly tested against the ever-evolving ML stack. To facilitate our work, please adhere to the following guidelines:

Before merging, wait for a maintainer to clean and format the notebooks you're adding. You can tag @tcapelle.

Before marking the PR as ready for review, please run your notebook one more time. Restart the Colab and run all. We will provide you with links to open the Colabs below

The following colabs were changed -colabs/peft/llama_token_cls.ipynb

tcapelle commented 4 months ago

Hey, can you just use

import wandb
wandb.login()

instead?

SauravMaheshkar commented 4 months ago

Hey, can you just use

import wandb
wandb.login()

instead?

@tcapelle Addressed in 2fe5f12

tcapelle commented 4 months ago

Two extra small changes:

SauravMaheshkar commented 4 months ago

Two extra small changes:

  • remove the entity = "saurav" and default to None (so it' uses your default entity after calling wandb.login)
  • Add the image to the peft folder and import it as a static image on the notebook (![](llama_image.png).

@tcapelle fixed in https://github.com/wandb/examples/pull/525/commits/7c7335863477a6de3ec378d8a9ddae096253b81a

tcapelle commented 4 months ago

extra detail, use a relative path to the image, so when we merge the path to your branch is not needed

SauravMaheshkar commented 4 months ago

extra detail, use a relative path to the image, so when we merge the path to your branch is not needed

The image is not in my fork of the wandb/examples repository but rather in my SauravMaheshkar/SauravMaheshkar repository. Ref

tcapelle commented 4 months ago

add it to the folder then