wandb / examples

Example deep learning projects that use wandb's features.
http://wandb.ai
1.11k stars 292 forks source link

Adds new artifacts colab. #526

Closed katjacksonWB closed 1 month ago

katjacksonWB commented 3 months ago

Adds a new Artifacts colab to replace the old, outdated one linked on the Artifacts landing page.

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 3 months ago

Thanks for contributing to wandb/examples! We appreciate your efforts in opening a PR for the examples repository. Our goal is to ensure a smooth and enjoyable experience for you 😎.

Guidelines

The examples repo is regularly tested against the ever-evolving ML stack. To facilitate our work, please adhere to the following guidelines:

Before merging, wait for a maintainer to clean and format the notebooks you're adding. You can tag @tcapelle.

Before marking the PR as ready for review, please run your notebook one more time. Restart the Colab and run all. We will provide you with links to open the Colabs below

The following colabs were changed -colabs/wandb-artifacts/Artifact_fundamentals.ipynb

noaleetz commented 3 months ago

Hey @katjacksonWB - some feedback from reviewing the whole thing:

tcapelle commented 3 months ago

Ping me when ready for final review/merge

noaleetz commented 2 months ago

Why we don't show the classic:

# you can log using the one-liner:
wandb.log_artifact("file.csv", name="my_artifact", type="data")

# or
at = Artifact(name="my_artifact",  type="data")
at.add_file("file.csv")
# add_dir(...)
wandb.log_artifact(at)
  • Shouldn't this live in wandb-artifacts?
  • Please also replace the "old outdated one"

is referring to a specific line?

tcapelle commented 2 months ago

Why we don't show the classic:

# you can log using the one-liner:
wandb.log_artifact("file.csv", name="my_artifact", type="data")

# or
at = Artifact(name="my_artifact",  type="data")
at.add_file("file.csv")
# add_dir(...)
wandb.log_artifact(at)
  • Shouldn't this live in wandb-artifacts?
  • Please also replace the "old outdated one"

is referring to a specific line?

This plan and the code don't match:

image

You are doing 2+3+4 in one line.

tcapelle commented 2 months ago

I would also use this PR to remove/replace old stuff in wandb-artifacts (and put this file in there as a getting started)

noaleetz commented 2 months ago

Hey @rymc - would you be up to revising the changes you proposed directly? Katherine is out on medical leave so I am trying to get some support with wrapping up her in-flight docs PR so we can get the new and improved Artifacts colab out. If it is easy enough to make those fixes directly that would be a huge help so I can focus on some of the other docs work.

rymc commented 1 month ago

Hey @noaleetz done. Addressed comments and confirmed working on Colab.

noaleetz commented 1 month ago

Hey @noaleetz done. Addressed comments and confirmed working on Colab.

Ryan you are awesome, thank you so so much. I will give the colab a final run myself, but we should be good to merge. @ngrayluna can I ask you to give your review and stamp as well?

rymc commented 1 month ago

Ah, good point @ngrayluna. I've pushed a new version that makes the Colab notebook executable regardless of where it runs.

ngrayluna commented 1 month ago

PR for small nits: https://github.com/wandb/examples/pull/548

tcapelle commented 1 month ago

can you make both wandbcode consistent?

ngrayluna commented 1 month ago

can you make both wandbcode consistent?

Not sure I follow?