wandb / terraform-aws-wandb

A terraform module for deploying Weights & Biases on AWS.
Apache License 2.0
17 stars 19 forks source link

Feature Request Operator | Support to pull MySQL credentials from secrets in the CR #284

Closed vijay-wandb closed 1 month ago

vijay-wandb commented 1 month ago

Description

Add support to pull MySQL credentials from Secrets when deploying CRD from yaml file.

helm-charts/charts/operator-wandb/values.yaml at main · wandb/helm-charts

mysql:
    host: ""
    port: 3306
    database: "wandb_local"
    user: "wandb"
    password: ""

This can be the entire configuration like we do here or at least the password pulled from secrets. Ex. what can look like the password

env:
    - name: MYSQL_PASS
      valueFrom:
        secretKeyRef:
          name: mysql-data
          key: mysql-pass
  mysql:
    host: ""
    port: 3306
    database: "wandb_local"
    user: "wandb"
    password: $(MYSQL_PASS)
amanpruthi commented 1 month ago

https://github.com/wandb/helm-charts/pull/222

abhinavg6 commented 1 month ago

@jsbroks @danielpanzella - Can we please review the PR here, when you get a chance? Thanks.