wandb / terraform-google-wandb

A Terraform module for deploying Weights & Biases on GCP.
Apache License 2.0
12 stars 6 forks source link

feat: Enabled workload identity access for kms and gcs #113

Closed amanpruthi closed 1 month ago

gls4 commented 4 months ago

Has this been tested against en existing cluster, as well as used to build a new cluster? When I try to apply this PR against a new managed install built using the master branch, I get these errors:

│ Error: Get "http://localhost/api/v1/namespaces/default/serviceaccounts/wandb-serviceaccount": dial tcp 127.0.0.1:80: connect: connection refused
│ 
│   with module.wandb.module.gke_app.kubernetes_service_account.default,
│   on .terraform/modules/wandb.gke_app/main.tf line 13, in resource "kubernetes_service_account" "default":
│   13: resource "kubernetes_service_account" "default" {
│ 
╵
╷
│ Error: Get "http://localhost/apis/scheduling.k8s.io/v1/priorityclasses/wandb-priority": dial tcp 127.0.0.1:80: connect: connection refused
│ 
│   with module.wandb.module.gke_app.kubernetes_priority_class.priority,
│   on .terraform/modules/wandb.gke_app/main.tf line 23, in resource "kubernetes_priority_class" "priority":
│   23: resource "kubernetes_priority_class" "priority" {
│ 
╵
╷
│ Error: Get "http://localhost/api/v1/namespaces/default/services/wandb": dial tcp 127.0.0.1:80: connect: connection refused
│ 
│   with module.wandb.module.gke_app.kubernetes_service.service,
│   on .terraform/modules/wandb.gke_app/main.tf line 241, in resource "kubernetes_service" "service":
│  241: resource "kubernetes_service" "service" {
│ 
╵
╷
│ Error: Get "http://localhost/api/v1/namespaces/default/services/prometheus": dial tcp 127.0.0.1:80: connect: connection refused
│ 
│   with module.wandb.module.gke_app.kubernetes_service.prometheus,
│   on .terraform/modules/wandb.gke_app/main.tf line 259, in resource "kubernetes_service" "prometheus":
│  259: resource "kubernetes_service" "prometheus" {
│ 
╵
╷
│ Error: Get "http://localhost/api/v1/namespaces/default/configmaps/wandb": dial tcp 127.0.0.1:80: connect: connection refused
│ 
│   with module.wandb.module.gke_app.kubernetes_config_map.config_map,
│   on .terraform/modules/wandb.gke_app/main.tf line 275, in resource "kubernetes_config_map" "config_map":
│  275: resource "kubernetes_config_map" "config_map" {
│ 
╵
╷
│ Error: Get "http://localhost/api/v1/namespaces/default/secrets/wandb": dial tcp 127.0.0.1:80: connect: connection refused
│ 
│   with module.wandb.module.gke_app.kubernetes_secret.secret,
│   on .terraform/modules/wandb.gke_app/main.tf line 285, in resource "kubernetes_secret" "secret":
│  285: resource "kubernetes_secret" "secret" {
│ 

I'm attaching the full output of terraform plan as well. gcp-terraform-log.txt

jsbroks commented 2 months ago

@amanpruthi we are merge without security