wandb / terraform-google-wandb

A Terraform module for deploying Weights & Biases on GCP.
Apache License 2.0
12 stars 6 forks source link

feat: Add optional path var for instance level bucket path #145

Closed levinandrew closed 3 weeks ago

levinandrew commented 2 months ago
Terraform will perform the following actions:

  # module.wandb.data.google_compute_forwarding_rules.all will be read during apply
  # (depends on a resource or a module with changes pending)
 <= data "google_compute_forwarding_rules" "all" {
      + id    = (known after apply)
      + rules = (known after apply)
    }

  # module.wandb.module.wandb.helm_release.wandb will be updated in-place
  ~ resource "helm_release" "wandb" {
        id                         = "wandb-cr"
      ~ metadata                   = [
          - {
...
              - values         = jsonencode(
                    {
                      - name = "wandb"
                      - spec = <<-EOT
...
                                "bucket":
                                  "name": "andrew-levin-gcp-intense-goblin"
                                  "path": ""
                                  "provider": "gcs"
                                "cloudProvider": "gcp"
 ...

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

The new helm release spec wasn't shown when running terraform apply, but the updates are propagated to the deployment as expected:

jsbroks commented 3 weeks ago

This PR is included in version 5.3.0 :tada: