search

wandb / terraform-google-wandb

A Terraform module for deploying Weights & Biases on GCP.
Apache License 2.0
12 stars 6 forks source link

fix: Add GKE delete protection switch #160

Closed flamarion closed 2 weeks ago

flamarion commented 2 weeks ago

This may prevent us to remove a GCP deployment if we set the deletetion_protection = true by default.

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster

Note
On version 5.0.0+ of the provider, you must explicitly set deletion_protection = false and run terraform apply to write the field to state in order to destroy a cluster.
flamarion commented 2 weeks ago

I also did run terraform fmt -recursive . to get all the TF code formated.

flamarion commented 2 weeks ago

The #161 accumulated this PR, so I'm going to close it.