search

wandb / terraform-google-wandb

A Terraform module for deploying Weights & Biases on GCP.
Apache License 2.0
12 stars 6 forks source link

chore: Switch node image to cos_containerd #44

Closed cavila-evoliq closed 1 year ago

cavila-evoliq commented 1 year ago

GKE Clusters running kubernetes version 1.23 and newer do not support new node pools running the Docker-based COS image. Additionally, support for Docker-based COS images is dropped entirely in 1.24. (source)

So we upgrade the node pool image from COS to COS_CONTAINERD.

flamarion commented 1 year ago

Maybe we need to add another keeper here to get the node pool updated when the cluster gets upgraded.

The cluster will be upgraded because the current STABLE release channel version is 1.23, and the one we're using is still in 1.22.

But if we don't want the cluster upgraded, we will also need to add a maintenance exclusion and add a lifecycle to ignore changes.

GCP docs for the No Upgrades maintenance exclusion https://cloud.google.com/kubernetes-engine/docs/concepts/maintenance-windows-and-exclusions#scope_of_maintenance_to_exclude

flamarion commented 1 year ago

Hi @cavila-evoliq thank you for your PR. We just merged another one #46, after a more extensive test on the impact of this change on all other customers.

If you switch to the latest version of our module you will get the feature available.

If you have any other questions, please, feel free to reach out to us.