search

wandb / terraform-google-wandb

A Terraform module for deploying Weights & Biases on GCP.
Apache License 2.0
12 stars 6 forks source link

feat: Update redis reserved ip range and Add deletion protection to database #92

Closed venky-wandb closed 7 months ago

venky-wandb commented 7 months ago

Situation: Screen Shot 2023-12-11 at 3 46 05 PM When trying to install REDIS, it tries to establish a private services access connection with a shared VPC network. When creating this for Tower, somehow the reserved IP we have set for Redis appears to be in use.

Solution: Screen Shot 2023-12-11 at 3 44 56 PM In order to get around that, I had to create the REDIS on a different reserved IP range than the hard-coded one we use. So this PR makes it a configurable parameter. Test to show this works

Situation 2: None of our GCP databases have deletion protection enabled because there are two different variables to control the deletion protection. More on the thread here

Solution: Screen Shot 2023-12-11 at 3 58 12 PM Enable deletion protection at all levels (GCP, gcloud, CLI etc.) and not just at terraform deletion level. Test to show this works

jsbroks commented 7 months ago

This PR is included in version 1.22.0 :tada: