fix: Don't submit note form if Enter event pressed as part of IME

wandb / weave

Weave is a toolkit for developing AI-powered applications, built by Weights & Biases.

https://wandb.me/weave

Apache License 2.0

659 stars 49 forks source link

fix: Don't submit note form if Enter event pressed as part of IME #2099

Closed jamie-rasmussen closed 1 month ago

jamie-rasmussen commented 1 month ago

Internal Slack: https://weightsandbiases.slack.com/archives/C03BSTEBD7F/p1723216451475369?thread_ts=1723207818.976219&cid=C03BSTEBD7F Internal Jira: https://wandb.atlassian.net/browse/WB-20311

Fix for IME - the Enter key is used for hiragana to kanji input on a Japanese language keyboard, we were prematurely submitting feedback notes when the user pressed Enter.

circle-job-mirror[bot] commented 1 month ago

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=cbc46aa2c34acb1431d597d289252b2b81a6f2b4