wandb / weave

Weave is a toolkit for developing AI-powered applications, built by Weights & Biases.
https://wandb.me/weave
Apache License 2.0
659 stars 49 forks source link

chore: remove dead redirect code #2132

Closed jamie-rasmussen closed 1 month ago

jamie-rasmussen commented 1 month ago

At the time we were adding the new sidebar (https://github.com/wandb/core/pull/20661/) we also added redirecting of the /entity/project page to the traces page when the project has Weave data and no Models data.

Browse3 has similar redirection code, taking you from /entity/project/weave to the traces page.

In its current state, the code always redirects you to the traces page. It was doing a query to see if the project has published data and showing a loader, but this is unnecessary if we're going to redirect regardless of the result.

The query is particularly bad because the limit parameter to useRootObjectVersions does not get passed along and used as it should, so it is fetching all of the object information for the project even though we only cared about a non-zero count.

circle-job-mirror[bot] commented 1 month ago

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=4b85166de5211256fdc43413eed8e513f8c035c6