search

wandb / weave

Weave is a toolkit for developing AI-powered applications, built by Weights & Biases.
https://wandb.me/weave
Apache License 2.0
720 stars 67 forks source link

The feedback emojis modal takes 5+ seconds to load on some devices #2485

Open SamMakesThings opened 1 month ago

SamMakesThings commented 1 month ago

As the title says, the feedback emoji selection model can take over 5 seconds to load on some devices every time. This was reported on Mac OS Safari, but it seems to also occur on Chrome on that user's device. I wasn't able to replicate it on my own in Safari or Chrome.

Looking in Chrome DevTools, the problem seems to be that the system is re-fetching every emoji image every time the model is opened. We might consider caching those images for performance / efficiency purposes.

image

Again, I wasn't able to replicate, so take this with a grain of salt. Probably a low priority improvement.

Initially reported by Alex Reibman.

andrewtruong commented 1 month ago

Thanks, I think I've also seen this issue raised before -- cc: @jamie-rasmussen

jamie-rasmussen commented 1 month ago

The internal ticket is https://wandb.atlassian.net/browse/WB-21093 and a related ticket on the library we use is https://github.com/ealush/emoji-picker-react/issues/404