search

wandenberg / nginx-push-stream-module

A pure stream http push technology for your Nginx setup. Comet made easy and really scalable.
Other
2.22k stars 295 forks source link

compile failed on OSX 10.9 & nginx 1.5.7 & 0.4.0 #118

Closed jerzyk closed 10 years ago

jerzyk commented 10 years ago

compile log: https://gist.github.com/jerzyk/b6d79495540d06d20d8a

wandenberg commented 10 years ago

Please check issue #114

jerzyk commented 10 years ago

OSX 10.9 does not have gcc, there is a gcc but as link to clang, issue #114 shows resolution for OSX 10.8.x

e.g. running gcc:

$ gcc
clang: error: no input files

afaik Apple depreciated gcc some time ago, but forced this in the latest OS, so IMHO there are two options: to support clang or say that this modue is not working on the new OSX-ex at all..

moret commented 10 years ago

Third option: help yourself, investigate the issue and propose a change, as is suggested on LLVM's compatibility page: http://clang.llvm.org/compatibility.html#inline .

The message indicates that three functions are declared as inline in src/ngx_http_push_stream_module_utils.c and rc/ngx_http_push_stream_module_utils.c . I changed these three methods to static and was able to compile the module just fine: https://gist.github.com/moret/7927811

Bye.

jerzyk commented 10 years ago

Not everybody is so great and brilliant and knows c, so you do not need to be mean. But, thank you for the pointers - I hope you will be able to prepare a patch so whole community can appreciate your effort!

Thanks.

wandenberg commented 10 years ago

Try the code on 0.4.1-dev branch, please.

jerzyk commented 10 years ago

compiled successfully, some warnings were generated, do you want me to post compile log?

wandenberg commented 10 years ago

If they are related with the module files, yes. Please.

On Wed, Dec 18, 2013 at 9:40 AM, jerzyk notifications@github.com wrote:

compiled successfully, some warnings were generated, do you want me to post compile log?

— Reply to this email directly or view it on GitHubhttps://github.com/wandenberg/nginx-push-stream-module/issues/118#issuecomment-30835181 .

jerzyk commented 10 years ago

from what I can see, those warnings are related to ssl (at the end there is something related to the module) but nginx has the same issues, imho they will dissapear when nginx will be updated...

https://gist.github.com/jerzyk/5fa8f0930825d7394260