search

wandenberg / nginx-push-stream-module

A pure stream http push technology for your Nginx setup. Comet made easy and really scalable.
Other
2.22k stars 295 forks source link

JSON statistics shouldn't quote integers #221

Closed mjanda closed 8 years ago

mjanda commented 8 years ago

I ran into an issue when trying to monitor pushstream stats using InfluxData Telegraf - it can scan any JSON and extract variables, but only takes into account numeric fields - and quoted numbers are considered a string, not a number.

I'm keeping PID quoted because it's more like a description than value that could be measured.

I've had some problems running complete test suite, but rspec spec/mix/channel_statistics_spec.rb completes without failure. Looks like you're casting everything to int there anyway.

wandenberg commented 8 years ago

@mjanda Thanks for your contribution. I merged your changes just with a different commit message and updating the channel_statistics_spec.rb tests.

Which problems did you have running the tests? (I can try to make it more easy/stable to run)