search

wandenberg / nginx-push-stream-module

A pure stream http push technology for your Nginx setup. Comet made easy and really scalable.
Other
2.21k stars 295 forks source link

Unload event is deprecated #309

Closed d-javu closed 2 months ago

d-javu commented 3 months ago

The unload event is deprecated and Lighthouse complains and docks a few points.

See the following for information on deprecation: https://developer.mozilla.org/en-US/docs/Web/API/Window/unload_event https://developer.chrome.com/docs/web-platform/deprecating-unload

The unload event is used to call disconnect(), which the browser will do for us anyway when navigating away from the page.

Is there some necessary magic going on here, or should handling of the unload event just be dropped?

See pull request: #310

sunnychun commented 3 months ago

您的信已收到，我将尽快给您答复

wandenberg commented 2 months ago

Thanks for calling my attention to this @d-javu