wandenberg / redis_nginx_adapter

Adapter to use hiredis with async connections inside a nginx module
MIT License
27 stars 12 forks source link

event attach does not check for error #7

Open whatvn opened 5 years ago

whatvn commented 5 years ago

https://github.com/wandenberg/redis_nginx_adapter/blob/f3f3cbd47b2c63d72cc315d3d2acf8ae6bfb2c99/redis_nginx_adapter.c#L75

redis_nginx_event_attach won't add event data into current context if there's error. This could cause error later if we use context. Should we just clean up data and return error instead of keep going likes the current way?