search

wandera / 1password-client

Python wrapper for OnePassword CLI developed at Wandera.
MIT License
47 stars 25 forks source link

If a newer CLI version is present, the installer will try to overwrite it. #50

Closed costingalan closed 10 months ago

costingalan commented 10 months ago

Describe the bug If a newer version is present, the installer will try to overwrite it.

To Reproduce Steps to reproduce the behavior:

  1. Have a newer CLI version installed (currently, the code has 2.19.0)
  2. Try to Install the client (via pip)

Expected behavior Installation should succeed.

Additional info Code is checking exact match: if op == cli_version:

dtpryce commented 10 months ago

Nice spot! One issue is that the cli isn't always backwards compatible and so we have to be careful when to install. I'll have a quick chat with the team and come back to you on your PR today.

costingalan commented 10 months ago

Thanks for the reply, @dtpryce ! I understand the reasoning. Maybe we can return a warning that the client hasn't been tested with the newer version and still let the user install the package.

dtpryce commented 10 months ago

Sorry I totally let this one slip!

dtpryce commented 10 months ago

@costingalan your PR has been merged (thanks) and all present in 1.0.6 of the code now on PyPi 🎉