search

wandera / 1password-client

Python wrapper for OnePassword CLI developed at Wandera.
MIT License
47 stars 25 forks source link

Get item by title #57

Open cpinflux opened 8 months ago

cpinflux commented 8 months ago

Is your feature request related to a problem? Please describe.

The get_item call should accept a title, not just a uuid. It's a lot of extra waiting time to go get the uuid first and then get the item based on it.

Describe the solution you'd like

This should be a valid function call: op.get_item("myItem", vault="Private")

Being picky, the title is not a --option in the op cli, so equivalently should be the default, unnamed option required by the function.

dtpryce commented 8 months ago

Thanks for opening an issue, we will try to look at it in detail soon but if you want to contribute via a PR feel free! One quick glance what you're asking for makes sense (matching the cli better) and shouldn't be a massive change but just for safety we would roll this into at least a minor version maybe a major since it's potentially backward incompatible for those already using the lib.