feat: add support for otp fields

wandera / 1password-client

Python wrapper for OnePassword CLI developed at Wandera.

MIT License

47 stars 25 forks source link

feat: add support for otp fields #61

Closed fzipi360 closed 4 months ago

fzipi360 commented 4 months ago

what

add support for otp fields

why

there is no support for otp as it requires a specific flag to be passed to 1pass cli

fzipi360 commented 4 months ago

🤔 from what I see here, there is not much room for mocking there... unless creating everything from scratch.

dtpryce commented 4 months ago

🤔 from what I see here, there is not much room for mocking there... unless creating everything from scratch.

yeah it's nothing special since we are just wrapping the cli happy for it be:

def test_get_item_otp(self):
        """
        Tested in read_bash_return.
        """
        pass

Just for completeness

dtpryce commented 4 months ago

🤔 from what I see here, there is not much room for mocking there... unless creating everything from scratch.

yeah it's nothing special since we are just wrapping the cli happy for it be:
def test_get_item_otp(self):
        """
        Tested in read_bash_return.
        """
        pass
Just for completeness

ok I will test that this works but no reason why it wouldn't and add the test for you so you can focus on the comma within fields PR.

dtpryce commented 4 months ago

Merged in #62 ... will release soon