search

waneck / testrepo

0 stars 0 forks source link

Issue 973 - override + @:overload - haxe #973

Open waneck opened 11 years ago

waneck commented 11 years ago

[Google Issue #973 : http://code.google.com/haxe/issues/detail?id=973] by ncanna...@gmail.com, at 2012-06-20T09:13:02.000Z The change in implementation of @:overload no longer allows overrides (unless you copy manually overloads in subclass)

Accessing the super field is a too early since it might still not be defined at the time we define our subclass class_field

waneck commented 11 years ago

[comment from waneck, published at 2012-06-20T16:56:16.000Z] Maybe it's time to support @:overload function ... ? :)

waneck commented 11 years ago

[comment from ncanna...@gmail.com, published at 2012-06-20T20:06:44.000Z] ouch ouch :) I don't think we can make it for 2.10

waneck commented 11 years ago

[comment from ncanna...@gmail.com, published at 2012-07-14T10:54:26.000Z]

waneck commented 11 years ago

[comment from waneck, published at 2012-08-19T09:43:15.000Z] I'm attaching the patch that solves this issue and chooses the overloaded function that fits correctly for review.

waneck commented 11 years ago

[comment from waneck, published at 2012-08-19T11:18:46.000Z] This new attachment now solves the problems with type parameters

waneck commented 11 years ago

[comment from si...@haxe.org, published at 2013-02-09T16:51:48.000Z] We have to make a final call here soon if this goes into haxe 3 or not. I could look into Caues patch and work on the implementation, but this would take me several hours which might be better spent on documentation/specification.

waneck commented 11 years ago

[comment from si...@haxe.org, published at 2013-02-20T12:51:08.000Z] Is this resolved?

waneck commented 11 years ago

[comment from waneck, published at 2013-02-20T13:36:18.000Z] it's resolved only for pf_overload. It would take one less check in the typer.ml to be able to do it for all platforms

waneck commented 11 years ago

[comment from si...@haxe.org, published at 2013-02-21T07:15:42.000Z] Do we want this fixed for any non-pf_overload platforms?

waneck commented 11 years ago

[comment from ncanna...@gmail.com, published at 2013-02-21T08:02:36.000Z] Let's push that to 3.2

waneck commented 11 years ago

[comment from si...@haxe.org, published at 2013-02-24T17:12:14.000Z]