wang-nima / snappy

Automatically exported from code.google.com/p/snappy
Other
0 stars 0 forks source link

Wrap #include "config.h" with HAVE_CONFIG_H #27

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Building snappy without using standard ./configure; make steps 
 (e.g., using Visual Studio, etc.)

What is the expected output? What do you see instead?
An error, config.h is not found, occurs at snappy-stubs-internal.h 

What version of the product are you using? On what operating system?
snappy-1.0.1, and the latest revision 22

Please provide any additional information below.

Please wrap config.h import with HAVE_CONFIG_H guard to achieve the portability.
#ifdef HAVE_CONFIG_H
#include "config.h"
#endif 

By applying the attached patch, I can successfully build snappy in Windows with 
Visual C++, mingw-g++, etc. 

Original issue reported on code.google.com by taroleo on 30 Mar 2011 at 2:33

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by se...@google.com on 30 Mar 2011 at 10:59

GoogleCodeExporter commented 9 years ago
Fixed in r25.

Original comment by se...@google.com on 30 Mar 2011 at 8:28

GoogleCodeExporter commented 9 years ago

Original comment by se...@google.com on 30 Mar 2011 at 8:30