wang-nima / snappy

Automatically exported from code.google.com/p/snappy
Other
0 stars 0 forks source link

configure.ac: Consider using AS_IF instead of the shell's if #8

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Use AS_IF instead of directly using the shell's `if`: 
http://www.gnu.org/software/hello/manual/autoconf/Limitations-of-Builtins.html#L
imitations-of-Builtins and 
http://www.gnu.org/s/hello/manual/autoconf/Common-Shell-Constructs.html .

Using AS_IF ensures that any required macro arguments in the then and else 
branches are expanded in advance of the actual if statement. I don't think 
they're technically required here, but I believe their liberal use to be better 
autoconf style. This is a personal opinion thing, though.

Original issue reported on code.google.com by endgame....@gmail.com on 22 Mar 2011 at 11:49

GoogleCodeExporter commented 9 years ago
I tried this and it got rather messy; especially when nesting several AS_IFs, 
the readability goes down the drain. Thus, given that there's no practical 
reason for the change, I'm going to leave this as-is for now.

Original comment by se...@google.com on 24 Mar 2011 at 1:27