search

wangfeiping / flares

flares - Not for one, but for all
6 stars 1 forks source link

IBC transfer didn't rollback? #2

Open wangfeiping opened 4 years ago

wangfeiping commented 4 years ago

$ rly tx transfer ibc0 flares 3samoleans cosmos1xevvpcwchgqccymftuh2vavjtujr2r79gafxfh $ rly tx relay demo -d

I[2020-10-21|21:48:45.600] Executed block module=state height=346 validTxs=0 invalidTxs=0 I[2020-10-21|21:48:45.605] Committed state module=state height=346 txs=0 appHash=6A1D939705706A4DFD09C72387D525EEB660BE59A58410AE67B66B86A4694913 E[2020-10-21|21:48:46.191] IBC transfer: it's not allowed to IBC transfer to a contract receiver address module=flares/x/bank height=346 receiver=cosmos1xevvpcwchgqccymftuh2vavjtujr2r79gafxfh E[2020-10-21|21:48:46.675] IBC transfer: it's not allowed to IBC transfer to a contract receiver address module=flares/x/bank height=347 receiver=cosmos1xevvpcwchgqccymftuh2vavjtujr2r79gafxfh I[2020-10-21|21:48:46.676] Executed block module=state height=347 validTxs=1 invalidTxs=0 I[2020-10-21|21:48:46.682] Committed state module=state height=347 txs=1 appHash=16DA0CDEC55B47C39DFFC5B5BD949749F2BD4428CE263933F71846B08DC8F680 I[2020-10-21|21:48:47.730] Executed block module=state height=348 validTxs=0 invalidTxs=0 I[2020-10-21|21:48:47.735] Committed state module=state height=348 txs=0 appHash=00D5A21FBCF062C2CB908710E568CEFAE612C910B38052EF0369313A46F07317

wangfeiping commented 4 years ago

and the result is not correct. the balance of flares(IBC receiver address) is correct, the balance of ibc0(IBC sender address) is not correct.

How to rollback a failled IBC TX?

wangfeiping commented 4 years ago

Codes: https://github.com/wangfeiping/flares/blob/9e270104d889f126f34cba2f65a39ca0aa9cc94d/x/bank/keeper/keeper_wrapper.go#L138