Open wanghejin opened 10 months ago
We definitely agree that the undo
and redo
command can show the past commands that are being undone/redone. However, we feel that it is not in scope as this augmentation would require us to store the CommandResult
into every state of the VersionedAddressBook
, and rectifying it is less important (based on the value/effort considerations) than the work that has been done already. Moreover, the user would commonly use the undo
or redo
command when they make mistakes, so they would have known what commands went wrong. In addition, many applications that we use today also do not indicate to the user what has been undone/redone (such as word docs/excel), and the user is left to see it on his own, which is why we did not feel like it was too important to implement this in our feature.
[The team marked this bug as a duplicate of the following bug]
Would be helpful if undo/redo stated what action was taken
A message stating what was undone will be helpful, especially since the person may not remember exactly what the previous/next command refers to, especially when undo allows multiple consecutive runs.
[original: nus-cs2103-AY2324S1/pe-interim#4466] [original labels: type.FeatureFlaw severity.Medium]
[This is the team's response to the above 'original' bug]
We definitely agree that the
undo
andredo
command can show the past commands that are being undone/redone. However, we feel that it is not in scope as this augmentation would require us to store theCommandResult
into every state of theVersionedAddressBook
, and rectifying it is less important (based on the value/effort considerations) than the work that has been done already. Moreover, the user would commonly use theundo
orredo
command when they make mistakes, so they would have known what commands went wrong. In addition, many applications that we use today also do not indicate to the user what has been undone/redone (such as word docs/excel), and the user is left to see it on his own, which is why we did not feel like it was too important to implement this in our feature.Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: [replace this with your explanation]
The undo/redo command does not tell me what is undone/redone. So I couldn't really remember what are the actions to be undone/redone. Especially that multiple actions can be undone. The user can practically just undo all the way.