search

wanghejin / pe

0 stars 0 forks source link

Duplicate person with names having different whitespace allowed #5

Open wanghejin opened 10 months ago

wanghejin commented 10 months ago

I feel that we should not allow two people have the same name, but only with difference in whitespace because they are very likely to be the same person.

image.png

nus-se-script commented 9 months ago

Team's Response

Hi, thanks for this report. I am the dev responsible for this issue, and hence I'll be responding. We do actually mention the limitations of our duplication system in appendix C of the user guide; we have followed the requirements set in the CS2103 website regarding duplication detection.

Capture.PNG

Capture.PNG

We consider this as sufficiently informing the user of our limitations (we can't exactly inform the user of the limitations inside the app). Hence we believe that this is not in scope for v1.4.

As a side note; it is unclear what your input was. Did you have 3 or 4 spaces? If you have 3 whitespaces, it should have shown you a warning as per appendix C. If it had 4, it should not have warned you (since this is what we define similarity as!) Here is our attempt to recreate your input with 3 whitespaces.

Capture.PNG

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]