wangjunbao / webp

Automatically exported from code.google.com/p/webp
0 stars 0 forks source link

Can't make centos 5 rpm package #172

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

gif2webp.c:114: error: expected declaration specifiers or '...' before 'GifWord'

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by laokanli...@gmail.com on 10 Sep 2013 at 7:41

GoogleCodeExporter commented 9 years ago
Issue 173 has been merged into this issue.

Original comment by jz...@google.com on 11 Sep 2013 at 7:25

GoogleCodeExporter commented 9 years ago
I looked quickly, it seems preserving this type by name is unnecessary: int 
should suffice for a table lookup.

For reference what version of libgif are you building against?

Original comment by jz...@google.com on 11 Sep 2013 at 7:27

GoogleCodeExporter commented 9 years ago
this bug reason is the giflib viersion on centos is low , the header file not 
contain the GifWord struct , I update the centos 5 's giflib to the 4.1.6 this 
bug will be fixed

Original comment by laokanli...@gmail.com on 12 Sep 2013 at 1:17

GoogleCodeExporter commented 9 years ago
The code in gif2webp can be changed, better to provide compatibility. I didn't 
go through the releases to see when GifWord was added, so I was curious about 
the offending version.

Original comment by jz...@google.com on 13 Sep 2013 at 7:17

GoogleCodeExporter commented 9 years ago
Urvang, ping.

Original comment by jz...@google.com on 11 Dec 2013 at 4:28

GoogleCodeExporter commented 9 years ago
Ahh, this went out of my radar. Thanks for the reminder.

It seems that GifWord was introduced in 4.1.4, so the prior versions are 
affected by this issue. I'll replace GifWord by int and test the code on 4.1.3

Original comment by urv...@google.com on 11 Dec 2013 at 3:49

GoogleCodeExporter commented 9 years ago
This patch should fix it: https://gerrit.chromium.org/gerrit/#/c/68062/

Original comment by urv...@google.com on 11 Dec 2013 at 5:09

GoogleCodeExporter commented 9 years ago
This has been merged:
d493455 gif2webp: Backward compatibility for giflib version <= 4.1.3

Original comment by jz...@google.com on 11 Dec 2013 at 10:27