search

wangkuiyi / gotorch

A Go idiomatic binding to the C++ core of PyTorch
MIT License
305 stars 35 forks source link

Close `gocv.Mat`s that we forgot to close #353

Closed shendiaomo closed 3 years ago

shendiaomo commented 3 years ago

gocv.Mats must be released manually. They didn't choose SetFinalizer, see https://github.com/hybridgroup/gocv/issues/411 for details.

codecov[bot] commented 3 years ago

Codecov Report

Merging #353 into develop will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #353      +/-   ##
===========================================
+ Coverage    87.45%   87.47%   +0.01%     
===========================================
  Files           33       33              
  Lines         1467     1469       +2     
===========================================
+ Hits          1283     1285       +2     
  Misses         121      121              
  Partials        63       63
Impacted Files Coverage Δ
vision/imageloader/imageloader.go 88.39% <100.00%> (+0.21%) :arrow_up: