search

wangkuiyi / recordio

Apache License 2.0
11 stars 2 forks source link

Fix encoding problem #36

Closed zou000 closed 5 years ago

zou000 commented 5 years ago

fix #30

zou000 commented 5 years ago

Right. Will file an issue and fix it. -- Li

On Tue, May 28, 2019 at 11:52 AM Yi Wang notifications@github.com wrote:

@wangkuiyi commented on this pull request.

In python/tests/recordio_test.py https://github.com/wangkuiyi/recordio/pull/36#discussion_r287921541:

@@ -77,6 +77,34 @@ def test_io_failures(self):

         recordio.Scanner("", index=idx)

     idx.close()

  • def test_utf8_values(self):

  • filename can be in UTF-8

  • path = "/tmp/文件.recordio"

As we are comparing the content read from the file with the content we wrote, we might need to call https://golang.org/pkg/io/ioutil/#TempFile to create the temporary file; otherwise, simultaneous writings by multiple test runs might conflict and ruin the content of the file.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wangkuiyi/recordio/pull/36?email_source=notifications&email_token=AADV3ANXMC5VIMYPLEVZESLPXST7JA5CNFSM4HP7PPSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZZVAAI#pullrequestreview-242438145, or mute the thread https://github.com/notifications/unsubscribe-auth/AADV3AJ237TZU7GQMPNBJQDPXST7JANCNFSM4HP7PPSA .