search

wanglingsong / JsonSurfer

A streaming JsonPath processor in Java
MIT License
294 stars 55 forks source link

Regression in 1.5.0 #54

Closed thierrylegrain closed 5 years ago

thierrylegrain commented 5 years ago

Hello,

In 1.4.3, I have a code working well like that : surfer.configBuilder() .bind("$.header", (JsonPathListener) (final Object value, final ParsingContext context) -> { }).bind("$.data[?(@.device-type=='vmanage')]", (JsonPathListener) (final Object value, final ParsingContext context) -> { }) .bind("$.data[?(@.device-type=='vsmart')]", (JsonPathListener) (final Object value, final ParsingContext context) -> { }) .buildAndSurf(entity.getContent()); Now, in 1.5.0, only the first bind found data. No data for the second and third bind (we have data with version 1.4.3) If you removed the third bind, the second bind has data. From my point of view, you have an issue when you have several binding with a filter on same attribute.

wanglingsong commented 5 years ago

Could you provide the sample json as well?

thierrylegrain commented 5 years ago

I attached an example example.json.txt

wanglingsong commented 5 years ago

You are right. It is a bug! I'll try to fix it and add corresponding test case for it soon.

thierrylegrain commented 5 years ago

Hi Leo,

Thank you for this quick analysis and answer.

Regards, Thierry. From: Leo Wang Sent: jeudi 13 juin 2019 19:42 To: jsurfer/JsonSurfer JsonSurfer@noreply.github.com Cc: Thierry Legrain tlegrain@infovista.com; Author author@noreply.github.com Subject: Re: [jsurfer/JsonSurfer] Regression in 1.5.0 (#54)

You are right. It is a bug! I'll try to fix it and add corresponding test case for it soon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jsurfer/JsonSurfer/issues/54?email_source=notifications&email_token=AGJHZE6RJOAVBQLS3FF2PPTP2KBHLA5CNFSM4HXZ64GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXUPUHQ#issuecomment-501807646, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGJHZE7LLBYPJGOQX3JP7FTP2KBHLANCNFSM4HXZ64GA.

wanglingsong commented 5 years ago

@thierrylegrain Hi, I just committed a fix. Sorry for the late update.

thierrylegrain commented 5 years ago

Hi Léo,

No problem. Thank you so much.

Regards, Thierry. From: Leo Wang Sent: lundi 8 juillet 2019 14:17 To: jsurfer/JsonSurfer JsonSurfer@noreply.github.com Cc: Thierry Legrain tlegrain@infovista.com; Mention mention@noreply.github.com Subject: Re: [jsurfer/JsonSurfer] Regression in 1.5.0 (#54)

@thierrylegrainhttps://github.com/thierrylegrain Hi, I just committed a fix. Sorry for the late update.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/jsurfer/JsonSurfer/issues/54?email_source=notifications&email_token=AGJHZE3XXITDDAC5EKCUZH3P6MV4RA5CNFSM4HXZ64GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZM4YGI#issuecomment-509201433, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGJHZEZF2XWY6IA2XV7PGSTP6MV4RANCNFSM4HXZ64GA.