wangp / bower

A curses terminal client for the Notmuch email system
Other
119 stars 11 forks source link

Build error: `process.m:301:5: error: call to undeclared function`: implicit function declarations not allowed by ISO C99 #115

Closed hgvhgv closed 8 months ago

hgvhgv commented 8 months ago

I moved to a new computer and rebuilt bower. Along the way I encountered the following errors related to implicit functions

process.m:301:5: error: call to undeclared function 'sigemptyset'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    sigemptyset(&sigmask);
    ^
process.m:302:5: error: call to undeclared function 'sigaddset'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    sigaddset(&sigmask, SIGWINCH);
    ^
process.m:3102:14: error: call to undeclared function 'kill'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    int rc = kill(Pid, Signal);
             ^
3 errors generated.
** Error making `Mercury/os/process.o'.
make[1]: *** [bower] Error 1
make: *** [bower] Error 2

I was able to build bower by turning off these errors via src/Mercury.params

CFLAGS += -Wno-error=implicit-function-declaration

There seems to be a some amount of disagreement about how to handle these such implicit function declarations, whether they should be warnings or ignored totally rather than errors. So just FYI!

wangp commented 8 months ago

Can you check if it's fixed on master?

hgvhgv commented 8 months ago

Yes, works for me! Thanks!