Thread pane is too small

[csabahenk]

I see the size of the thread pane is hard-coded to be capped at 8. That's a miserable user experience when trying to find my way through a lengthy thread on my hidpi screen.

I could get as far by myself as to change the value of max_thread_lines in _threadpager.m from 8 to 80 (that's about half of my terminal height), but I think a more complete solution would be desirable, involving some of the following possibilities:

• make it a config option
• instead having a hard-coded cap, make it proportional to the terminal size
• allow the thread pane be interactively resized with keys

[wangp]

Adding a configuration option is easy, but I've tried not to have too many random knobs for things in this project so I consider it a last resort.

Interactively resizing would be possible. That screen is pretty loaded with keybinds, though.

It would be best to experiment with the automatic calculation a bit to find a better compromise.

For very long threads probably we ultimately need to ability to collapse/expand sub-threads to make navigating them easier. I don't really see such big threads in my own usage these days.

[vivien]

+1 for no option. I'm using bower out of the box without the need to write a configuration file for it for a while now.

On Wed, Jun 10, 2020 at 10:43 AM wangp notifications@github.com wrote:

Adding a configuration option is easy, but I've tried not to have too many random knobs for things in this project so I consider it a last resort.

Interactively resizing would be possible. That screen is pretty loaded with keybinds, though.

It would be best to experiment with the automatic calculation a bit to find a better compromise.

For very long threads probably we ultimately need to ability to collapse/expand sub-threads to make navigating them easier. I don't really see such big threads in my own usage these days.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wangp/bower/issues/60#issuecomment-642056378, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACFY4BFBOWGWUV3SPXE7VTRV6L2RANCNFSM4NZMVZ5Q .

[csabahenk]

While I'm not convinced either that a config option is the right approach, not wanting to set it does not sound to be the most apt counter argument. The availability of an option does not mandate one to set it (or to learn about it atl).

[seifferth]

@csabahenk I just made a pull request for one possible solution. Maybe you could drop me a quick note if this would work for you.

[wangp]

Hopefully good enough now.